fix: double escaped paths#2216
Merged
Merged
Conversation
pd93
added a commit
that referenced
this pull request
Apr 28, 2025
This was referenced Jul 9, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2208
in #2075 (released in v3.43.1), we changed the way that expanding paths works so that it directly uses mvdan's
expand.Literal. However, this has resulted in us double-escaping paths because of our internalescapefunction. Switching top.Documentand removing theescapefunction seems to fix the problem.I have double-checked that issues like #1551, #1590 and #2073 have not regressed.