fix(fish): honor GO_TASK_PROGNAME for experiments cache

[SergioChan]

Summary

• use $GO_TASK_PROGNAME instead of hardcoded task when refreshing fish completion experiment cache
• fixes fish completion warnings on distros where the binary name is go-task
• keeps completion behavior unchanged for default task installs

Testing

• git diff --check
• go test ./... (not runnable in this environment: required Go toolchain go1.25 is unavailable via GOTOOLCHAIN download)

Related

• Fixes Task completion with the fish shell raise a warning when distro use the go-task name instead of task #2727

[trulede]

Fix seems OK.
I'm not familiar with fish and can't verify.

[appenzellergeller]

I did face the same issue today and have already tried the fix as it is proposed in this PR.
This will unfortunately not work in any case.

The are situations where the __go_task_is_experiment_enabled is called from another script and then the variable $GO_TASK_PROGNAME has not been defined in that scope.

If you add the --inherit-variable GO_TASK_PROGNAME to the function then it will work. See below.

function __go_task_get_experiments --inherit-variable GO_TASK_PROGNAME
[...]
    # Refresh cache
    set -g __go_task_experiments_cache ($GO_TASK_PROGNAME --experiments 2>/dev/null)
[...]
end

[trulede]

Would you check if the suggested changes are viable/working:

function __go_task_get_experiments --inherit-variable GO_TASK_PROGNAME
[...]
    # Refresh cache
    set -g __go_task_experiments_cache ($GO_TASK_PROGNAME --experiments 2>/dev/null)
[...]
end

[SergioChan]

Thanks for the repro details and suggestion — I pushed an update to this PR.

What changed

• Added --inherit-variable GO_TASK_PROGNAME to __task_get_experiments in completion/fish/task.fish.
• This ensures the helper keeps access to GO_TASK_PROGNAME when invoked through __task_is_experiment_enabled from other completion contexts.

Validation

• Attempted: go test ./...
• Result: could not run in this environment because the required Go 1.25 toolchain is unavailable.

If you want, I can also add --inherit-variable GO_TASK_PROGNAME to __task_is_experiment_enabled for extra explicitness, but this change should address the scope issue reported here.

[SergioChan]

Thanks for the concrete fish-shell suggestion (--inherit-variable GO_TASK_PROGNAME) and for testing this path.

I’ll incorporate that approach and push an update.

[vmaerten]

Thanks !