fix: log the checked files if verbose#924
Closed
aminya wants to merge 1 commit into
Closed
Conversation
Member
|
Hi @aminya, thanks for creating this PR. I gave this some thought and decided to close because:
|
Member
|
I just opened #931 to track this idea. |
Contributor
Author
|
Thanks. Could you please make an issue for the Glob errors too? The glob package that you use is not validated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a logging step to the function that checks if the inputs/generates are up to date. After hours of debugging, It helped me to finally detect that the globbing library that
taskuses fails to check some patterns.The following checks the files inside the
devfolderBut this doesn't!
Or for example,
**doesn't check all the files of the current project.Performance-wise, this is not a good solution because it calls the glob outside the
checker.IsUpToDatefunction. I did this because that was the only way I could access the logger without changing the checker API. If you are OK with the API change, we can remove the duplicate glob calls.