Skip to content

fix: some installations not detecting Task version correctly #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pd93 merged 1 commit into from
Mar 27, 2023
Merged

fix: some installations not detecting Task version correctly #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- Fixed some installations (e.g. Brew) not detecting the Task version correctly (#13, #14 by @pd93).

## v0.1.0 - 2023-03-26

- View tasks in the sidebar.
Expand Down
2 changes: 1 addition & 1 deletion src/services/taskfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class TaskfileService {

parseVersion(stdout: string): semver.SemVer | undefined {
// Extract the version string from the output
let matches = stdout.match(/v(\d+\.\d+\.\d+)/);
let matches = stdout.match(/(\d+\.\d+\.\d+)/);
if (!matches || matches.length !== 2) {
return undefined;
}
Expand Down