Conversation
Micro benchmark shows a 20x speed-up; binary size also decrease from 18KB to 12KB
Micro benchmark shows around 4x speed-up and 30% binary size reduction.
Micro benchmark shows around 5x speed-up and 3x binary size reduction.
Micro benchmark shows around 7x speed-up and 2x binary size reduction.
Micro benchmark shows around 27x speed-up (!) and almost 2x binary size reduction.
|
Side note : Several test files in I propose to delete these files once you have reviewed and reproduced the benchmark. |
|
I was about to review this too, but realised that it has all the #225 changes as well, once that is landed I guess the diff will be readable? |
Yes, that was my precisly my intent. |
|
I've merged #225 , meaning the diffs on this branch should be easier to review. There are still a large number of changes, but many of them are only renaming. |
|
I tried to get the changeset to stop reflecting commits from #225 by changing the PR base branch, but it didn't help. @benoitkugler, would you rebase this on |
|
Hum... rebasing seems quite painfull here. |
|
Closing in favor of #236 |
This PR is a follow up of #225, including 3 changes improving performances :
segmenterto avoid applying unnecessary rulesSee the two benchmarks (comparison is with #225) :
goos: linux
goarch: amd64
pkg: github.com/go-text/typesetting/segmenter
cpu: Intel(R) Core(TM) i7-4610M CPU @ 3.00GHz