Conversation
dominic-r
added
area:frontend
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for authentik-integrations ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dominic-r
force-pushed
the
sdko/source-icon-invert-fix
branch
from
5e5194f to
df97324
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20176 +/- ##
==========================================
- Coverage 92.26% 92.25% -0.02%
==========================================
Files 1032 1032
Lines 59654 59755 +101
Branches 2537 2537
==========================================
+ Hits 55042 55128 +86
- Misses 4547 4564 +17
+ Partials 65 63 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dominic-r
changed the title
|
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-91411ee5efb6a76d53aa55859a259e761d756266
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)sAfterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-91411ee5efb6a76d53aa55859a259e761d756266Afterwards, run the upgrade commands from the latest release notes. |
kensternberg-authentik
left a comment
kensternberg-authentik
left a comment
There was a problem hiding this comment.
It isn't broken, but there are two places where there's either cut-and-paste or code re-implementation. I request but do not require that you consider updating those.
dominic-r
force-pushed
the
sdko/source-icon-invert-fix
branch
from
b437d80 to
0d3a638
Compare
BeryJu
left a comment
BeryJu
left a comment
There was a problem hiding this comment.
backend looks mostly good, some thoughts though:
I'd prefer if we could implement this in a less-theme focused manner, for example ThemedUrlSerializer -> DynamicURLSerializer to also allow things like different variants for high contrast, reduced motion, and maybe even locale
3 participants
This PR makes source icons theme-aware across the UI.
Built-in sources can now expose light and dark icon variants through icon_themed_urls, and the source consumers that render icons now choose the correct variant for the active theme. The PR also keeps icon_url populated for compatibility, so existing clients do not lose default source icons.
Why: Before this change, source icons were effectively single-variant in many places. Dark mode either used the same asset everywhere or relied on inversion, which is fragile and breaks for icons that need distinct artwork per theme.
Some notes: https://authentiksecurity.slack.com/archives/C08C0SCU2JV/p1770339223464779?thread_ts=1770338237.366879&cid=C08C0SCU2JV
Closes: #11387
Some screenshots on Light / Dark mode: