Add Godot 4.x camera module support with display rotation and CameraFeed formats#89
Open
shiena wants to merge 21 commits intogodot-sdk-integrations:masterfrom
Open
Add Godot 4.x camera module support with display rotation and CameraFeed formats#89shiena wants to merge 21 commits intogodot-sdk-integrations:masterfrom
shiena wants to merge 21 commits intogodot-sdk-integrations:masterfrom
Conversation
shiena
force-pushed
the
feature/update-camera
branch
from
faad3cf to
d86f9f3
Compare
Author
|
This pull request contains changes for the upcoming 4.6 release, so I'll mark it as ready for review once 4.6 is released. |
shiena
force-pushed
the
feature/update-camera
branch
from
d86f9f3 to
902be2a
Compare
shiena
force-pushed
the
feature/update-camera
branch
3 times, most recently
from
045a4f6 to
962664c
Compare
shiena
force-pushed
the
feature/update-camera
branch
from
68a5e51 to
47a4cf4
Compare
Co-authored-by: Jason Kuo <j20001970@gmail.com>
- Check focus/exposure/white balance mode support before setting (fixes front camera crash) - Check lockForConfiguration return value before device configuration - Add canSetSessionPreset check with fallback to AVCaptureSessionPresetHigh - Add canAddInput/canAddOutput checks with proper cleanup on failure - Add windowScene nil check for iOS 13+ orientation detection - Add pixel buffer plane count check before accessing planes - Fix format index mismatch between set_format/activate_feed and get_formats - Add ERR_FAIL_NULL checks for device in set_device/activate_feed/set_format/get_formats - Use one-time error logging for per-frame callbacks to prevent log spam
- Remove videoSettings override that forced FullRange output - Camera now outputs VideoRange (native format) for consistency with ARKit - Reduces conversion overhead and matches Godot shader expectations
shiena
force-pushed
the
feature/update-camera
branch
from
47a4cf4 to
585e374
Compare
Author
|
I switched this PR from draft to ready for review since Godot 4.6 has been released. |
shiena
force-pushed
the
feature/update-camera
branch
from
585e374 to
8302ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split from godotengine/godot#106305 and merge from godotengine/godot#106777
This PR adds comprehensive Godot 4.x support for the iOS camera module with the following improvements:
camera_ios.mm(Godot 3.x) andcamera_ios_4x.mm(Godot 4.x) to reduce#ifdirective complexityhandle_display_rotation_change()support for Godot 4.6+ to properly handle camera feed orientation when device rotatesget_formats()andset_format()for Godot 4.5+ allowing users to query and select camera formatsset_monitoring_feeds()instead of constructor, following the new CameraServer patternVersion Compatibility
camera_ios.mm(unchanged behavior)