Fix build by locking conan version to most recent 1.x to resolve incompatibilities with conan 2.x#35
Merged
fire merged 1 commit intogodotengine:masterfrom Apr 14, 2023
dvanderleij:master
Merged
Fix build by locking conan version to most recent 1.x to resolve incompatibilities with conan 2.x#35fire merged 1 commit intogodotengine:masterfrom dvanderleij:master
fire merged 1 commit intogodotengine:masterfrom
dvanderleij:master
Conversation
dvanderleij
changed the title
Member
|
The pr looks ok. If the tests pass I can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build from example in the build.yaml I realised that the conan version was not locked during building and since 2.x has released in the meantime which changed the api this broke the GitHub actions build. Locking the version to 1.58 for now seems to repair the build. I have little to no knowledge of conan so i would know how to upgrade to 2.x.