Fix webrtc example that relied on JSON integers#1171
Draft
goatchurchprime wants to merge 2 commits intogodotengine:masterfrom
Draft
Fix webrtc example that relied on JSON integers#1171goatchurchprime wants to merge 2 commits intogodotengine:masterfrom
goatchurchprime wants to merge 2 commits intogodotengine:masterfrom
Conversation
Member
|
Isn't this a workaround, not a solution? JSON numbers are, in fact, floats. Any check like |
fire
changed the title
aaronfranke
added
the
waiting for godot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem identified by godotengine/godot#103374
The
JSON.parse_string()creates floats instead of integers from numbers, which the example flagged as an error. The solution is to send integers as strings instead.