Skip to content

Check for pending clears in every RD texture function.#113236

Merged
akien-mga merged 1 commit into
godotengine:masterfrom
blueskythlikesclouds:rd-pending-clear-fix
Nov 27, 2025
Merged

Check for pending clears in every RD texture function.#113236
akien-mga merged 1 commit into
godotengine:masterfrom
blueskythlikesclouds:rd-pending-clear-fix

Conversation

@blueskythlikesclouds
Copy link
Copy Markdown
Member

Fixes regression introduced in #108871.

Missing checks for pending clears can cause the clear to happen after a command has already written to the texture, and wipe its result.

Fixes Voxel GI rendering on D3D12.

@akien-mga akien-mga merged commit 79432b6 into godotengine:master Nov 27, 2025
20 checks passed
@akien-mga
Copy link
Copy Markdown
Member

Thanks!

@akien-mga akien-mga added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 8, 2026
@akien-mga
Copy link
Copy Markdown
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 8, 2026
@blueskythlikesclouds blueskythlikesclouds deleted the rd-pending-clear-fix branch January 15, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants