Add a dialog for customizing FBX import#59810
Conversation
Does this supercede #30675 then? |
|
@fire-forge yeah I guess |
fire
left a comment
There was a problem hiding this comment.
Reviewed the overview design and it looks good. Did not go over in fine detail.
editor/fbx_importer_manager.h
Outdated
There was a problem hiding this comment.
This class is only relevant of the FBX importer exists, so it should go in the modules/gltf/editor/ folder together with the importer.
There was a problem hiding this comment.
The only thing I don't know yet how to do if moving this as I suggested, is how to the entry in the Settings menu.
|
Need a rebase. |
|
@fire feel free to take it over if you want |
|
@akien-mga I think I need to remake the branch or can I edit reduz's branch? |
|
@fire If you want, you can push to reduz's fork. We just need to be sure he doesn't delete it 🙃 |
|
I completely forgot about this code. |
|
I'm updating #30675 to get it merged, I'll rework this PR then. |
f87a195 to
3b015f4
Compare
3b015f4 to
5c481ad
Compare
|
It's not perfect but it should be good enough to merge, in parallel with godotengine/FBX2glTF#27 and godotengine/godot-website#392. |
* If FBX files are found, a dialog will pop up asking to configure FBX2glTF. * Dialog can also be accessed by going Editor -> Configure FBX Import. * The dialog also shows a link to click to download the converter, which should contain instructions.
5c481ad to
e93d991
Compare
akien-mga
left a comment
There was a problem hiding this comment.
Let's merge this for now, can be improved further later on.
|
Thanks! |
uriproperty toLinkButton#30675 )Note that the link is non functional yet. The website needs to be created.