Remove unnecessary value assignments throughout the codebase#78538
Merged
YuriSizov merged 1 commit intogodotengine:masterfrom Jul 12, 2023
Merged
Remove unnecessary value assignments throughout the codebase#78538YuriSizov merged 1 commit intogodotengine:masterfrom
YuriSizov merged 1 commit intogodotengine:masterfrom
Conversation
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
LGTM, these all make sense
CPPcheck found most of them. no need to assign the variable twice: - AnimationTrackEditTypeAudio - SSEffects variable is assigned in all if-else clauses: - EditorHelp - AndroidInputHandler - MenuBar - ShaderCompiler same if clause: - ItemList clearing an empty bitfield has no effect: - Viewport
Sauermann
force-pushed
the
fix-code-simplifications
branch
from
7e40bb9 to
890fdd5
Compare
akien-mga
approved these changes
Jun 21, 2023
YuriSizov
changed the title
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPPcheck found most of them.
no need to assign the variable twice:
variable is assigned in all if-else clauses:
same if clause:
clearing an empty bitfield has no effect: