Skip to content

Reimplement scene change#78988

Merged
YuriSizov merged 1 commit intogodotengine:masterfrom
RandomShaper:fix_change_scene
Jul 26, 2023
Merged

Reimplement scene change#78988
YuriSizov merged 1 commit intogodotengine:masterfrom
RandomShaper:fix_change_scene

Conversation

@RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Jul 3, 2023 •
edited by akien-mga
Loading

Maybe fixes #78788.
Maybe fixes #70910.

Bugsquad edit:

@RandomShaper RandomShaper added this to the 4.2 milestone Jul 3, 2023
@RandomShaper RandomShaper requested a review from a team as a code owner July 3, 2023 16:11
@YuriSizov
Copy link
Contributor

YuriSizov commented Jul 3, 2023

The title says "Avoid too early removal of current scene", but you've moved it to an even earlier point, kinda 🤔 I don't think queue_freeing it would be sufficient. I think we also need to unparent the node first, so we stop processing.

@RandomShaper RandomShaper marked this pull request as draft July 3, 2023 16:17
@RandomShaper RandomShaper changed the title Avoid too early removal of current scene in change_scene() Reimplement scene change Jul 4, 2023
@RandomShaper
Copy link
Member Author

RandomShaper commented Jul 4, 2023

I've changed the PR to a new approach.

@RandomShaper RandomShaper marked this pull request as ready for review July 4, 2023 11:30
@RandomShaper RandomShaper requested a review from a team as a code owner July 4, 2023 11:30
YuriSizov
YuriSizov reviewed Jul 4, 2023
View reviewed changes
This was referenced Jul 11, 2023
Closed
Closed
@RandomShaper
Copy link
Member Author

RandomShaper commented Jul 26, 2023

This one would be good for 4.2 dev builds.

@YuriSizov YuriSizov merged commit e8df8c5 into godotengine:master Jul 26, 2023
@YuriSizov
Copy link
Contributor

YuriSizov commented Jul 26, 2023

Thanks!

@RandomShaper RandomShaper deleted the fix_change_scene branch July 26, 2023 17:32
@Calinou Calinou mentioned this pull request Nov 20, 2023
Closed
This was referenced Nov 22, 2023
Merged
Closed
Closed
Merged
@kleonc kleonc mentioned this pull request Dec 2, 2023
Open
@kleonc kleonc mentioned this pull request Dec 2, 2023
Closed
@Lippanon Lippanon mentioned this pull request Dec 6, 2023
Open
@timothyqiu timothyqiu mentioned this pull request Dec 18, 2023
Closed
@YuriSizov
Copy link
Contributor

YuriSizov commented Jan 23, 2024

Given the changes in behavior, we shouldn't cherry-pick this.

@kleonc kleonc mentioned this pull request Mar 12, 2025
Closed
@nathanfranke nathanfranke mentioned this pull request Mar 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@YuriSizov YuriSizov YuriSizov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug topic:core

Projects

None yet

Milestone

4.2

2 participants

@RandomShaper @YuriSizov