GDScript: Add static analysis error reporting in GDScriptCache::get_full_script()#79163
Merged
YuriSizov merged 1 commit intogodotengine:masterfrom Jul 14, 2023
Merged
Conversation
vnen
approved these changes
Jul 7, 2023
anvilfolk
force-pushed
the
fullscripterror
branch
from
bc0f904 to
9550496
Compare
Contributor
Author
|
Pushed to the wrong branch - the code has not changed from since this was approved :) |
Contributor
|
Thanks! |
YuriSizov
changed the title
GDScriptCache::get_full_script()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
GDScriptCache::get_full_script()emits errors during file opening and parsing, but not during static analysis or compilation. This PR changes it so analysis/compilation errors are emitted.It is essentially a continuation of what #76954 did for
GDScriptCache::get_shallow_script().