Fix Extra Cull Margin triggers worst LOD#79191
Closed
fire wants to merge 1 commit intogodotengine:masterfrom
Closed
Fix Extra Cull Margin triggers worst LOD#79191fire wants to merge 1 commit intogodotengine:masterfrom
fire wants to merge 1 commit intogodotengine:masterfrom
Conversation
It introduces a new condition that checks if the transformed AABB (Axis-Aligned Bounding Box) contains the camera's origin point. If it does, it calculates a scale factor based on the distance between the camera and the center of the AABB, and applies this factor to adjust the distance value.
Contributor
|
I'm confused... What exact case is this code addressing and how does it do it? |
Contributor
|
Now that #79590 is merged, we should reevaluate if this is still something desired or not. |
Member
Author
|
Will revisit in the future. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT PR.
It introduces a new condition that checks if the transformed AABB (Axis-Aligned Bounding Box) contains the camera's origin point. If it does, it calculates a scale factor based on the distance between the camera and the center of the AABB, and applies this factor to adjust the distance value.
Fixes: #67890