Fix issue with LOD selection when Camera is inside Meshes AABB#79589
Closed
0010200303 wants to merge 1 commit intogodotengine:masterfrom
0010200303:master
Closed
Fix issue with LOD selection when Camera is inside Meshes AABB#795890010200303 wants to merge 1 commit intogodotengine:masterfrom 0010200303:master
0010200303 wants to merge 1 commit intogodotengine:masterfrom
0010200303:master
Conversation
Fixed an issue where the LOD was selected only based of the Meshes AABB support points although the Camera being inside the AABB.
Contributor
|
@0010200303 Hey there! Did you intend to close this PR? |
Contributor
Author
|
@YuriSizov Heyy thanks for checking. Yeah i intented to close this because it had a bad clang format and i didn't how to fix it so i just created a new one. |
Contributor
|
I see, #79590 supersedes this. In future, you can just push to the same branch, including force-pushing and rewriting entire history, to update your PR. I also recommend not using your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where the LOD was selected only based of the Meshes AABB support points although the Camera being inside the AABB.