Change precedence in rules to make location after proper casing. #81304
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Sep 7, 2023
Conversation
Member
|
This breaks unit tests, needs to be checked |
Member
Author
|
oh yeah forgot I had made some unit test on those that would folllow the rules so need to update those. I'll do that tonight. |
ajreckof
force-pushed
the
Change-precedence-in-rules-to-make-location-after-proper-casing-
branch
from
c087bf9 to
95317d2
Compare
YuriSizov
reviewed
Sep 5, 2023
YuriSizov
reviewed
Sep 5, 2023
ajreckof
force-pushed
the
Change-precedence-in-rules-to-make-location-after-proper-casing-
branch
from
95317d2 to
f8121bd
Compare
ajreckof
force-pushed
the
Change-precedence-in-rules-to-make-location-after-proper-casing-
branch
from
f8121bd to
364aac7
Compare
ajreckof
force-pushed
the
Change-precedence-in-rules-to-make-location-after-proper-casing-
branch
from
364aac7 to
19632ea
Compare
Member
|
Thanks! |
ajreckof
deleted the
Change-precedence-in-rules-to-make-location-after-proper-casing-
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if it is wanted or not might need a proposal. See #81104 (comment) on why this might be a good idea.
Just posting the PR as I was the one making this part of the code and knew how to change it if need be