Implemented {project} placeholder for external dotnet editor#81847
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Sep 20, 2023
Merged
Implemented {project} placeholder for external dotnet editor#81847akien-mga merged 1 commit intogodotengine:masterfrom
{project} placeholder for external dotnet editor#81847akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
raulsntos
reviewed
Sep 18, 2023
Member
There was a problem hiding this comment.
Thanks for contributing to the .NET module! The changes look good, they're pretty much the same changes requested by @RedworkDE in #74517 (comment).
raulsntos
approved these changes
Sep 19, 2023
Member
raulsntos
left a comment
There was a problem hiding this comment.
Looks good to me already. Since you are a new contributor, make sure to read CONTRIBUTING.md and the contributing documentation if you haven't already.
You'll need to squash the commits before this PR can be merged. The contributing documentation contains information about squashing in case you need it.
Feel free to reach out in the development chat if you need help.
79cd98e to
d756c26
Compare
Implements the {project} placeholder, available when setting an external editor
in the project settings, via Editor > Editor Settings > Text Editor > External
for the c# external editor, under Editor > Editor Settings > Dotnet > Editor,
This allows passing the project folder as a command line argument when using a
custom external editor that isn't one of the available options.
Fixes godotengine#81845
d756c26 to
c01a478
Compare
AThousandShips
approved these changes
Sep 20, 2023
Member
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
{project} placeholder for external dotnet editor
Contributor
|
Cherry-picked for 4.1.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #81845 , by mimicking the implementation at
godot/editor/plugins/script_editor_plugin.cpp
Lines 2291 to 2316 in 4df80b0
As the function
ProjectSettings::get_singleton()->get_resource_path()isn't exposed in the godot API, this solution instead makes use of ProjectSettings.GlobalizePath("res://"), which, on editor builds, returnsProjectSettings.resource_path + "/", according to its implementation atgodot/core/config/project_settings.cpp
Lines 257 to 272 in 4df80b0