Add error checks for DirAccess creation#82347
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Sep 26, 2023
Merged
Conversation
KoBeWi
approved these changes
Sep 26, 2023
Member
KoBeWi
left a comment
KoBeWi
left a comment
There was a problem hiding this comment.
Seems fine. We do have checks like that in many places and this PR just adds missing ones.
I only wonder whether they should be smarter than a generic fail in every case.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was noticed some crashes with invalid DirAccess objects. While I've not been able to determine the root cause yet, for safety, I've put error checks in places where a null DirAccess object might be returned in order to prevent hard crashes.