C#: Report diagnostic for Node exports in a type that doesn't derive from Node#82918
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Oct 27, 2023
Merged
Conversation
Contributor
|
@RedworkDE Would you mind giving this a review? |
RedworkDE
approved these changes
Oct 26, 2023
Member
RedworkDE
left a comment
RedworkDE
left a comment
There was a problem hiding this comment.
Only note that I have is that we kinda have GodotClasses to store type name constants like "Godot.Node" but that class doesn't seem to be used very consistently and currently doesn't have an entry for Node.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node-derived classes #82843[Export]members of typeNode(or derived) when the containing type is not aNode(or derived).