Skip to content

Project Manager: Open project when "Enter" is pressed when the search box is focused#83210

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
alfredbaudisch:manager-search-box-enter
Oct 13, 2023
Merged

Project Manager: Open project when "Enter" is pressed when the search box is focused#83210
akien-mga merged 1 commit intogodotengine:masterfrom
alfredbaudisch:manager-search-box-enter

Conversation

@alfredbaudisch
Copy link
Contributor

@alfredbaudisch alfredbaudisch commented Oct 12, 2023

In the project manager, when the Search Box is focused, the Key::Enter event is not being handled by ProjectManager::shortcut_input. So added a dedicated handler for the search box with the signal gui_input. Now when Enter is pressed, the highlighted project is opened.

Fixes and closes #73768.

@alfredbaudisch alfredbaudisch force-pushed the manager-search-box-enter branch from f2b4718 to c810fff Compare October 12, 2023 19:22
@akien-mga
Copy link
Member

Makes sense. But LineEdit has a text_submitted signal exactly for this, you don't need to reimplement it via _gui_input.

@alfredbaudisch alfredbaudisch force-pushed the manager-search-box-enter branch from c810fff to 0c584dd Compare October 13, 2023 06:54
@alfredbaudisch
Copy link
Contributor Author

Makes sense. But LineEdit has a text_submitted signal exactly for this, you don't need to reimplement it via _gui_input.

Done 👍

@akien-mga akien-mga changed the title Project Manager: open project when "Enter" is pressed when the search box is focused Project Manager: Open project when "Enter" is pressed when the search box is focused Oct 13, 2023
@akien-mga akien-mga merged commit f9c0c60 into godotengine:master Oct 13, 2023
@akien-mga
Copy link
Member

Thanks!

@alfredbaudisch alfredbaudisch deleted the manager-search-box-enter branch October 13, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project List's "Filter Projects" doesn't load first project on Enter key, but "Sort" field does

2 participants