Remove toggling of unique names in subscenes#83370
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Oct 28, 2023
Merged
Remove toggling of unique names in subscenes#83370akien-mga merged 1 commit intogodotengine:masterfrom
akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Member
|
ef93b28 to
439e008
Compare
Member
Author
|
Good thinking. Fixed! Though for the first issue you raised, the editor already does this, the ability to toggle the unique name off via the icon being a janky incongruity |
KoBeWi
reviewed
Oct 27, 2023
Member
|
It's still possible to toggle unique name using shortcut. |
439e008 to
479d71d
Compare
Member
Author
|
Good catch, I forgot about the shortcut since I don't think it's assigned by default. I've added the correct handling to the tool_selected case now. It will now simply disallow any toggling to unowned nodes. It will also only pop up the error dialog if ALL the nodes in the selection are unowned by the edited scene. I think this is the right call since it will still allow big batch converts on the entire scene even if a couple of editable children get caught in the selection. |
479d71d to
29c2615
Compare
KoBeWi
approved these changes
Oct 28, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some discussions, simply disallowing the ability to turn off the unique_name node flag in subscenes seems much more appropiate given how the system actually works. The unique name system works in the scope node ownership, so it does indeed make sense to disallow toggling it on the subscenes.
Deprecates previous attempt of fixing it here #82545