Fix inability to uncomment code in text shader editor#83822
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Oct 28, 2023
Merged
Conversation
dalexeev
reviewed
Oct 23, 2023
jsjtxietian
force-pushed
the
fix-can-not-uncomment-in-text-shader-editor
branch
from
628dbba to
961381c
Compare
SaracenOne
approved these changes
Oct 27, 2023
Member
SaracenOne
left a comment
SaracenOne
left a comment
There was a problem hiding this comment.
LGTM 👍
Tested, it works, and implementation looks fine. I also compared it with a previous similar PR I reviewed for the script editor, and it doesn't seem like any regressions have been introduced by fixing this. (#83382).
Member
|
Thanks! |
akien-mga
changed the title
akien-mga
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83821
The origin logic assumes delimiter is
#and thusleft(1), but in shader it's\\, so the logic for checking is_commented failed.