GLES3: Fix iOS Simulator by removing incorrect system_fbo overwrite#84955
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Nov 16, 2023
Merged
GLES3: Fix iOS Simulator by removing incorrect system_fbo overwrite#84955akien-mga merged 1 commit intogodotengine:masterfrom
system_fbo overwrite#84955akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
kisg
changed the title
BastiaanOlij
approved these changes
Nov 16, 2023
Contributor
BastiaanOlij
left a comment
BastiaanOlij
left a comment
There was a problem hiding this comment.
This makes perfect sense
bruvzg
approved these changes
Nov 16, 2023
akien-mga
changed the title
system_fbo overwrite
Member
|
Thanks! |
akien-mga
changed the title
system_fbo overwritesystem_fbo overwrite
Contributor
|
Cherry-picked for 4.1.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system_fbo static field is already initialized to zero, it should not be initialized again, when a TextureStorage instance is created, because it interferes with the iOS OpenGL initialization (see platform/ios/display_layer.mm).
This change fixes the OpenGL backend for the iOS Simulator and iOS devices.
Developed by Migeran, sponsored by Smirk Software.
Fixes #82917