Add a note for String::reverse to warn about its implementation#91321
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Apr 30, 2024
Merged
Add a note for String::reverse to warn about its implementation#91321akien-mga merged 1 commit intogodotengine:masterfrom
String::reverse to warn about its implementation#91321akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
Chaosus
force-pushed
the
doc_string_reverse
branch
2 times, most recently
from
8785817 to
5911b13
Compare
AThousandShips
added
the
cherrypick:4.2
Contributor
|
Just FYI it seems to be an extremely common limitation of Strings in many programming languages - I'd even go as far as to say it's an Unicode limitation instead of a language's |
Member
|
I'd say there are ways to do it but it's not normally done for performance, it's not so much a limitation as an expensive operation, I'd expect there to be a unicode method for accomplishing this |
Member
|
I think libicu makes this possible, but it likely requires having ICU data available, which isn't shipped by default when exporting a project as it's several dozen megabytes. |
mhilbrunner
reviewed
Apr 30, 2024
Chaosus
force-pushed
the
doc_string_reverse
branch
from
5911b13 to
d0af890
Compare
fire
approved these changes
Apr 30, 2024
Member
|
Thanks! |
akien-mga
removed
the
cherrypick:4.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a note for
String/StringNamedocs to warn user to not use emojis/compound symbols with that method. This is an addition for #78529 implementation.