Image: Add missing error printing to format specific functions#97780
Closed
dustdfg wants to merge 1 commit intogodotengine:masterfrom
Closed
Image: Add missing error printing to format specific functions#97780dustdfg wants to merge 1 commit intogodotengine:masterfrom
dustdfg wants to merge 1 commit intogodotengine:masterfrom
Conversation
akien-mga
changed the title
Calinou
reviewed
Nov 7, 2024
core/io/image.cpp
Outdated
Member
There was a problem hiding this comment.
Note for reviewers: This message is correct, as OpenEXR saving is only available in editor builds. Making it available in export templates has to be handled separately, e.g. using #73003.
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Calinou
reviewed
Nov 7, 2024
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Should be good to merge after applying suggestions.
Plus updated docs Note it doesn't affect load_from_file because it uses dynamic loaders while these functions are wrappers around direct calls to functions defined inside modules without using resource loader api Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com> Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
dustdfg
force-pushed
the
image_loader/more_disabled_module_warnings
branch
from
13c1956 to
a8e59f5
Compare
Contributor
Author
|
@Calinou ready for approve? |
Contributor
Author
|
I am not going to do anything to update this PR. But it is not bad in IMO so I am not closing it... There are people with "write access" so if you need it you can correct it. I am abandoning this PR... If you want close it |
Member
|
Member
|
I assume you wanted to close this one 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus updated docs
Note: it doesn't affect load_from_file because it uses dynamic loaders while these functions are wrappers around direct calls to functions defined inside modules without using resource loader api
Note: png functions weren't updated because png is a driver (not a module) and can't be disabled