feat: improve pipeline to publish release builds#170
Merged
nmerget merged 5 commits intogodotjs:masterfrom Oct 9, 2023
Merged
Conversation
Collaborator
|
Typical Godot Engine style is to use one commit because it makes code review easy to see, but it is opposite to common practice of showing historical work. Either style is acceptable. The pipeline appears to work. I'll go download the binary and report back. |
Collaborator
|
An initial screenshot works.
I would merge and work onwards since the cicd passes. I'm sure there'll be more bugs found when interacting with code. |
fire
approved these changes
Oct 7, 2023
Collaborator
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
You need to publish a tag to check if the system works. It's a catch-22.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add additional
workflow_callto publish build artifacts for releases