Skip to content

fix: issue with signals not taking params #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmerget merged 3 commits into from
Sep 20, 2024
Merged

fix: issue with signals not taking params #205

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c0e35f
fix: issue with signals not taking params
nmerget Sep 17, 2024
275552b
fix: issue with args from functions not found in editor
nmerget Sep 20, 2024
0a1064f
fix: issue with js_function_toString
nmerget Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: issue with js_function_toString
  • Loading branch information
@nmerget
nmerget committed Sep 20, 2024
commit 0a1064f8516de367c6ea23d61f0f671653655c57
3 changes: 2 additions & 1 deletion thirdparty/quickjs/quickjs/quickjs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37459,7 +37459,8 @@ static JSValue js_function_bind(JSContext *ctx, JSValueConst this_val,
return JS_EXCEPTION;
}

JSValue js_function_toString(JSContext *ctx, JSValueConst this_val)
JSValue js_function_toString(JSContext *ctx, JSValueConst this_val,
int argc, JSValueConst *argv)
{
JSObject *p;
JSFunctionKindEnum func_kind = JS_FUNC_NORMAL;
Expand Down
5 changes: 3 additions & 2 deletions thirdparty/quickjs/quickjs/quickjs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,10 +742,11 @@ JS_BOOL JS_SetConstructorBit(JSContext *ctx, JSValueConst func_obj, JS_BOOL val)
JSValue JS_NewArray(JSContext *ctx);
int JS_IsArray(JSContext *ctx, JSValueConst val);

JSValue js_function_toString(JSContext *ctx, JSValueConst this_val);
JSValue js_function_toString(JSContext *ctx, JSValueConst this_val,
int argc, JSValueConst *argv);
static js_force_inline JSValue JS_FunctionToString(JSContext *ctx, JSValueConst this_val)
{
return js_function_toString(ctx, this_val);
return js_function_toString(ctx, this_val, 0, NULL);
}

JSValue JS_GetPropertyInternal(JSContext *ctx, JSValueConst obj,
Expand Down