Conversation
|
This PR (HEAD: d5d0f1e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/743320. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Keith Randall: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-02-09T17:48:37Z","revision":"5a91551df92cce33f12a625df8a21e379b1485f2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Keith Randall: Patch Set 1: -Commit-Queue (Posted by golang-scoped@luci-project-accounts.iam.gserviceaccount.com on behalf of khr@golang.org) Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Nuno Cruces: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Keith Randall: Patch Set 2: Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
|
Message from Keith Randall: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/743320. |
This is motivated by wazero/wazero#2473 which needs to special case darwin for testing the availability of HasATOMICS, although all M-series CPUs support it. We could do sysctlbyname, like syscall_darwin_x86_gc.go, if that's preferred: https://developer.apple.com/documentation/kernel/1387446-sysctlbyname/determining_instruction_set_characteristics Change-Id: I0f5ea55ef5cda4956db44b2d40f2f10044fa3321 GitHub-Last-Rev: d5d0f1e GitHub-Pull-Request: #267 Reviewed-on: https://go-review.googlesource.com/c/sys/+/743320 Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Junyang Shao <shaojunyang@google.com>
|
This PR is being closed because golang.org/cl/743320 has been merged. |
This is motivated by
wazero/wazero#2473
which needs to special case darwin for testing the availability of
HasATOMICS, although all M-series CPUs support it.
We could do sysctlbyname, like syscall_darwin_x86_gc.go, if that's
preferred:
https://developer.apple.com/documentation/kernel/1387446-sysctlbyname/determining_instruction_set_characteristics