add(logging): Add OTel logging for counting chars#7903
add(logging): Add OTel logging for counting chars#7903NTaylorMullen merged 2 commits intogoogle-gemini:mainfrom
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @kiranani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request improves the granularity of telemetry data collected for code modifications. By adding character-level diff statistics to the existing line-level metrics, the system will gain deeper insights into how code changes are made, whether by the model or the user. This enhancement provides a more comprehensive understanding of code evolution and impact.
Highlights
- Enhanced Telemetry Data: This PR extends OpenTelemetry logging to capture character-level diff statistics, specifically model_added_chars, model_removed_chars, user_added_chars, and user_removed_chars. Previously, only line-level statistics were collected.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully adds character count metrics to the OpenTelemetry logging for tool calls that produce a diff. The changes correctly propagate the new diffStat fields through the ToolCallEvent and update the corresponding tests. My review includes one suggestion to improve code maintainability in packages/core/src/telemetry/types.ts by simplifying how the diffStat object is assigned to the event metadata.
Co-authored-by: Shnatu <snatu@google.com>
TLDR
We only have added and removed lines included in OTel. This change adds the character removals and additions too
Testing Matrix
Linked issues / bugs