Skip to content

add(logging): Add OTel logging for counting chars#7903

Merged
NTaylorMullen merged 2 commits intogoogle-gemini:mainfrom
kiranani:otel
Sep 7, 2025
Merged

add(logging): Add OTel logging for counting chars#7903
NTaylorMullen merged 2 commits intogoogle-gemini:mainfrom
kiranani:otel

Conversation

@kiranani
Copy link
Copy Markdown
Contributor

@kiranani kiranani commented Sep 6, 2025

TLDR

We only have added and removed lines included in OTel. This change adds the character removals and additions too

Testing Matrix

🍏 🪟 🐧
npm run

Linked issues / bugs

@kiranani kiranani requested a review from a team as a code owner September 6, 2025 21:40
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @kiranani, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the granularity of telemetry data collected for code modifications. By adding character-level diff statistics to the existing line-level metrics, the system will gain deeper insights into how code changes are made, whether by the model or the user. This enhancement provides a more comprehensive understanding of code evolution and impact.

Highlights

  • Enhanced Telemetry Data: This PR extends OpenTelemetry logging to capture character-level diff statistics, specifically model_added_chars, model_removed_chars, user_added_chars, and user_removed_chars. Previously, only line-level statistics were collected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds character count metrics to the OpenTelemetry logging for tool calls that produce a diff. The changes correctly propagate the new diffStat fields through the ToolCallEvent and update the corresponding tests. My review includes one suggestion to improve code maintainability in packages/core/src/telemetry/types.ts by simplifying how the diffStat object is assigned to the event metadata.

Comment thread packages/core/src/telemetry/types.ts
@gemini-cli gemini-cli Bot added kind/enhancement priority/p1 Important and should be addressed in the near term. labels Sep 6, 2025
@NTaylorMullen NTaylorMullen added this pull request to the merge queue Sep 7, 2025
Merged via the queue into google-gemini:main with commit 6a9c285 Sep 7, 2025
24 checks passed
@kiranani kiranani deleted the otel branch September 7, 2025 18:25
thacio added a commit to thacio/auditaria that referenced this pull request Oct 1, 2025
giraffe-tree pushed a commit to giraffe-tree/gemini-cli that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants