DASH Live stream stops playing multiperiod manifest

[bhjortsberg]

Issue description

Playing a DASH Live stream with multiperiods.
The player is stuck and stops playing when there is a new period. Sometimes the player continues after 30-60s and eventually the player also crashes with

07-10 11:52:25.114  9551  9551 D AndroidRuntime: Shutting down VM
07-10 11:52:25.133  9551  9551 E AndroidRuntime: FATAL EXCEPTION: main
07-10 11:52:25.133  9551  9551 E AndroidRuntime: Process: ---------, PID: 9551
07-10 11:52:25.133  9551  9551 E AndroidRuntime: java.lang.IndexOutOfBoundsException
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.util.Assertions.checkIndex(Assertions.java:68)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.source.dash.DashMediaSource$DashTimeline.getPeriod(DashMediaSource.java:1054)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.analytics.AnalyticsCollector$MediaPeriodQueueTracker.updateMediaPeriodToNewTimeline(AnalyticsCollector.java:778)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.analytics.AnalyticsCollector$MediaPeriodQueueTracker.onTimelineChanged(AnalyticsCollector.java:727)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.analytics.AnalyticsCollector.onTimelineChanged(AnalyticsCollector.java:424)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.ExoPlayerImpl$PlaybackInfoUpdate.notifyListeners(ExoPlayerImpl.java:746)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.ExoPlayerImpl.updatePlaybackInfo(ExoPlayerImpl.java:681)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.ExoPlayerImpl.handlePlaybackInfo(ExoPlayerImpl.java:622)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.ExoPlayerImpl.handleEvent(ExoPlayerImpl.java:567)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.google.android.exoplayer2.ExoPlayerImpl$1.handleMessage(ExoPlayerImpl.java:109)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:105)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:164)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6798)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
07-10 11:52:25.133  9551  9551 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Using an older version of ExoPlayer works fine (2.6.1).

Reproduction steps

See the provided DASH media presentation

Link to test content

Unfortunately no link but the manifest file that cases the issue:
manifest_period.mpd.txt

Version of ExoPlayer being used

Non-working version: 2.8.2
Working fine in: 2.6.1

Device(s) and version(s) of Android being used

Emulator Android 7.1.1 and OnePlus3T Android 8.0

Link

The following issue seem to be similar use case:
#3431

[ojw28]

@tonihei - The crash looks like a bug in MediaPeriodQueueTracker. I didn't get as far as reproducing, but my hypothesis is that:

1. There's an active period in the timeline.
2. The timeline updates and the period is removed. updateMediaPeriodToNewTimeline is called. newPeriodIndex is INDEX_UNSET for the removed period, and so the period entry is returned without being updated. Importantly, this means there may now be an entry in activeMediaPeriods with an invalid period index.
3. The timeline updates again. updateMediaPeriodToNewTimeline is called, and tries to use the invalid period index to access the timeline.

I think you'd normally expect onMediaPeriodReleased to happen between (2) and (3), which would avoid the problem, but I doubt that's guaranteed and it seems flaky to rely on it.

@bhjortsberg - For the playback getting stuck, this may be a result of invalid changes being made to the manifest. Unfortunately we can't determine whether this is the case just from a snapshot of the manifest. We'd need a working test stream ideally, or alternatively a sequence of manifest files showing how it changes over time.

[bhjortsberg]

It's possible that it can be something with the manifest, I can't see anything myself though. Attaching a sequence of manifest when the player get stuck. I think it's hard to get a working stream, but I can do a network capture if that would help.

I'm not sure if it get stuck when the old period (id: p_3_382868305) disappears from the manifest or when the new (id: p_3_382868325) is created.
Also in manifest_11.mpd there are 2 new segments compared to manifest_10.mpd, but that should not be a problem?

manifest_player_stop_08.mpd.txt
manifest_player_stop_09.mpd.txt
manifest_player_stop_10.mpd.txt
manifest_player_stop_11.mpd.txt
manifest_player_stop_12.mpd.txt
manifest_player_stop_13.mpd.txt

[ojw28]

The actual crash should be fixed now. Please could you try dev-v2 to see if your live stream still gets stuck (i.e. there's something else wrong), or whether the issue is now resolved?

[bhjortsberg]

Hi, yes the crash is fixed! However, the stream still gets stuck.

[ojw28]

Ok. I'm not sure we can do much about that without a live test stream, given we're unable to reproduce with other streams we have. I couldn't see anything obviously wrong from the manifests provided.