2.12.0 change in extractor handling

[Tolriq]

I'm heavily optimizing my application size via R8 and selection of the supported renderers and extractors to allow R8 to remove unused ones from final dex.

Since 2.12 despite still using :

extractorsFactory = ExtractorsFactory { arrayOf(Mp3Extractor(), FlacExtractor(), OggExtractor(), WavExtractor(), MatroskaExtractor(), Mp4Extractor()) }

and

ProgressiveMediaSource.Factory(dataSourceFactory, extractorsFactory).createMediaSource(MediaItem.Builder().setUri(finalUri).build())

All extractors are kept in final APK.

R8 gives the following reason:

com.google.android.exoplayer2.extractor.ts.TsExtractor
|- is referenced from:
|  int com.google.android.exoplayer2.extractor.ts.TsExtractor.read(com.google.android.exoplayer2.extractor.DefaultExtractorInput,com.google.android.exoplayer2.extractor.PositionHolder)
|- is overriding method:
|  int com.google.android.exoplayer2.extractor.Extractor.read(com.google.android.exoplayer2.extractor.DefaultExtractorInput,com.google.android.exoplayer2.extractor.PositionHolder)
|- is invoked from:
|  void com.google.android.exoplayer2.source.ProgressiveMediaPeriod$ExtractingLoadable.load()
|- is invoked from:
|  void com.google.android.exoplayer2.upstream.Loader$LoadTask.run()
|- is defined in library method overridden by:
|  com.google.android.exoplayer2.upstream.Loader$LoadTask
|- is instantiated in:
|  void com.google.android.exoplayer2.source.ProgressiveMediaPeriod.startLoading()
|- is invoked from:
|  void com.google.android.exoplayer2.source.ProgressiveMediaPeriod.prepare(com.google.android.exoplayer2.source.MediaPeriod$Callback,long)
|- is overriding method:
|  void com.google.android.exoplayer2.source.MediaPeriod.prepare(com.google.android.exoplayer2.source.MediaPeriod$Callback,long)
|- is invoked from:
|  void com.google.android.exoplayer2.ExoPlayerImplInternal.doSomeWork()
|- is invoked from:
|  boolean com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(android.os.Message)
|- is defined in library method overridden by:
|  com.google.android.exoplayer2.ExoPlayerImplInternal
|- is referenced from:
|  void com.google.android.exoplayer2.SimpleExoPlayer.updatePlayWhenReady(boolean,int,int)

Since APK size impact is huge it would be nice to see if this can be fixed.

[icbaker]

Can you provide instructions for me to reproduce what you're seeing?

A minimal reproducible example that demonstrates the problem in a way that we can build locally. This could be an Android Studio project on GitHub, or zipped up and sent to dev.exoplayer@gmail.com (with subject "Issue #7937").

[icbaker]

You may also want to take a look at https://exoplayer.dev/shrinking.html which was updated for 2.12 in 314758c.

Specifically you can now pass the custom ExtractorsFactory to SimpleExoPlayer rather than ProgressiveMediaSource.

[Tolriq]

When passing no extractorFactory to ProgressiveMediaSource it use DefaultExtractorsFactory that does refer all extractors and will keep them.

I tried passing the extractors to SimplExoPlayer but the result is the same:

com.google.android.exoplayer2.extractor.ts.TsExtractor
|- is referenced from:
|  int com.google.android.exoplayer2.extractor.ts.TsExtractor.read(com.google.android.exoplayer2.extractor.DefaultExtractorInput,com.google.android.exoplayer2.extractor.PositionHolder)
|- is overriding method:
|  int com.google.android.exoplayer2.extractor.Extractor.read(com.google.android.exoplayer2.extractor.DefaultExtractorInput,com.google.android.exoplayer2.extractor.PositionHolder)
|- is invoked from:
|  void com.google.android.exoplayer2.source.ProgressiveMediaPeriod$ExtractingLoadable.load()
|- is invoked from:
|  void com.google.android.exoplayer2.upstream.Loader$LoadTask.run()
|- is defined in library method overridden by:
|  com.google.android.exoplayer2.upstream.Loader$LoadTask
|- is instantiated in:
|  void com.google.android.exoplayer2.source.ProgressiveMediaPeriod.startLoading()
|- is invoked from:
|  void com.google.android.exoplayer2.source.ProgressiveMediaPeriod.prepare(com.google.android.exoplayer2.source.MediaPeriod$Callback,long)
|- is overriding method:
|  void com.google.android.exoplayer2.source.MediaPeriod.prepare(com.google.android.exoplayer2.source.MediaPeriod$Callback,long)
|- is invoked from:
|  void com.google.android.exoplayer2.ExoPlayerImplInternal.doSomeWork()
|- is invoked from:
|  boolean com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(android.os.Message)
|- is defined in library method overridden by:
|  com.google.android.exoplayer2.ExoPlayerImplInternal
|- is referenced from:
|  void com.google.android.exoplayer2.SimpleExoPlayer.updatePlayWhenReady(boolean,int,int)

I'm using exactly what is described in the shrinking page and it worked until 2.12.
It this part of test suite?
R8 extract I give from -whyareyoukeeping class com.google.android.exoplayer2.extractor.ts.TsExtractor is supposed to give you the exact reason of why the class is kept so have the answer in it.

[Tolriq]

bfe17ae

So I guess it's known and fixed in dev. Should have a note in changelog for impacted people to wait for 12.1.

I have also noticed that moving from 2.11.x into 2.12 caused my APK size to increase by around 220KB even though the app code remains the same. I am trying to provide a small sized player and this is not helping. I hope this issue gets solved. I am using R8.

[icbaker]

That commit you referenced is included in 2.12.0: 6290d09 There's no need to wait for 2.12.1 to pick up that code.

When you pass your customised ExtractorsFactory to ProgressiveMediaSource.Factory, are you also passing ExtractorsFactory.EMPTY to SimpleExoPlayer.Builder? As described here:

Note that if you provide a customized DefaultMediaSourceFactory, the ExtractorsFactory passed to the constructor of DefaultMediaSourceFactory will overwrite the passed to SimpleExoPlayer.Builder. To ensure code shrinking works as intended, you should provide ExtractorsFactory.EMPTY to the SimpleExoPlayer.Builder and pass your customized ExtractorsFactory to the DefaultMediaSourceFactory constructor: