StyledPlayerControlView: Constraints for minimal mode too conservative

[fountaingeyser]

With the introduction of the minimal mode the player controls become mostly unusable in many cases. When used in portrait mode on the OnePlus 7 with a 16:9 video the minimal mode is already activated. Consequently, none of the basic controls (e.g. VR or shuffle button) are reachable for users anymore.

A thorough investigation has revealed that the height of the player is considered too small to fit the default control views:

ExoPlayer/library/ui/src/main/java/com/google/android/exoplayer2/ui/StyledPlayerControlViewLayoutManager.java

Lines 565 to 589 in 4364b91

	private boolean useMinimalMode() {
	int width =
	styledPlayerControlView.getWidth()
	- styledPlayerControlView.getPaddingLeft()
	- styledPlayerControlView.getPaddingRight();
	int height =
	styledPlayerControlView.getHeight()
	- styledPlayerControlView.getPaddingBottom()
	- styledPlayerControlView.getPaddingTop();
	int centerControlWidth =
	getWidthWithMargins(centerControls)
	- (centerControls != null
	? (centerControls.getPaddingLeft() + centerControls.getPaddingRight())
	: 0);
	int defaultModeMinimumWidth =
	Math.max(
	centerControlWidth,
	getWidthWithMargins(timeView) + getWidthWithMargins(overflowShowButton));
	int defaultModeMinimumHeight =
	getHeightWithMargins(centerControls) + 2 * getHeightWithMargins(bottomBar);
	return width <= defaultModeMinimumWidth || height <= defaultModeMinimumHeight;
	}

Two possible solutions are:

1. Relax the constraints required to display the default user interface. As shown in our screenshots there is ample space to layout both the play/pause button and the bottom controls. This could be achieved by reducing padding or margins.
2. Provide fallback for all controls in minimal mode. This could be achieved with a simple overflow button and a bottom sheet or dialog with the basic controls (as illustrated e.g. by YouTube).

Minimal mode on OnePlus 7	Default mode on OnePlus 7

• ExoPlayer version number: 2.13.2
• Android version: Android 10
• Android device: OnePlus 7

[ojw28]

Agree there is an issue here. It looks like the padding of exo_center_controls is not being removed from the calculation, which I think it should be. There's also a problem horizontally where the edges of the far left/right icons can end up being clipped even when there is sufficient space for them to be fully rendered.