ACCESS_NETWORK_STATE crash 2.13.3

[yoobi]

I'm getting report from Crashlytics that some user are having crashes the stacktrace is as shown below:

Fatal Exception: java.lang.RuntimeException
Unable to create application com.my.application.PocApplication: java.lang.SecurityException: Package android does not belong to 10609
android.app.ActivityThread.handleMakeApplication (ActivityThread.java:7512)
android.app.ActivityThread.handleBindApplication (ActivityThread.java:7446)
android.app.ActivityThread.access$1500 (ActivityThread.java:301)
android.app.ActivityThread$H.handleMessage (ActivityThread.java:2148)
android.os.Handler.dispatchMessage (Handler.java:106)
android.os.Looper.loop (Looper.java:246)
android.app.ActivityThread.main (ActivityThread.java:8512)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:602)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1130)

android.os.Parcel.createExceptionOrNull (Parcel.java:2385)
android.os.Parcel.createException (Parcel.java:2369)
android.os.Parcel.readException (Parcel.java:2352)
android.os.Parcel.readException (Parcel.java:2294)
android.net.IConnectivityManager$Stub$Proxy.requestNetwork (IConnectivityManager.java:4597)
android.net.ConnectivityManager.sendRequestForNetwork (ConnectivityManager.java:4194)
android.net.ConnectivityManager.registerDefaultNetworkCallback (ConnectivityManager.java:4706)
android.net.ConnectivityManager.registerDefaultNetworkCallback (ConnectivityManager.java:4673)
com.google.android.exoplayer2.scheduler.RequirementsWatcher.registerNetworkCallbackV24 (RequirementsWatcher.java:136)
com.google.android.exoplayer2.scheduler.RequirementsWatcher.start (RequirementsWatcher.java:91)
com.google.android.exoplayer2.offline.DownloadManager.<init> (DownloadManager.java:278)
com.google.android.exoplayer2.offline.DownloadManager.<init> (DownloadManager.java:230)

Remote stack trace: at android.app.AppOpsManager.checkPackage(AppOpsManager.java:7783) at 
com.android.server.ConnectivityService.ensureSufficientPermissionsForRequest(ConnectivityService.java:8546) at
com.android.server.ConnectivityService.requestNetwork(ConnectivityService.java:8648) at 
android.net.IConnectivityManager$Stub.onTransact(IConnectivityManager.java:2051) at 
android.os.Binder.execTransactInternal(Binder.java:1190)

My manifest permission::

    <uses-permission android:name="android.permission.INTERNET" />
    <uses-permission android:name="android.permission.CHANGE_NETWORK_STATE" />
    <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
    <uses-permission android:name="android.permission.FOREGROUND_SERVICE"/>
    <uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />
    <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
    <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:ignore="ScopedStorage" />

The crash happened on

• ExoPlayer: 2.13.3
• Android version: 11
• Android device: Samsung Galaxy S20 FE 5G
• Rooted: no

[andrewlewis]

Do you have any other parts of the stack trace message apart from what's included above? In particular I was wondering if there is a line starting like AndroidRuntime: Caused by: java.lang.SecurityException:. [Internal: b/155549446] looks similar.

[yoobi]

Yes Indeed, i thought it was irrelevant as it wasn't on exoplayer library, I'll update my post. The order I display in my post is the same order I get from Crashlytics

[pavelperc]

We also got this crash. It is an android 11 bug, look here: https://stackoverflow.com/questions/66652819/getting-security-exception-while-trying-to-fetch-networkcapabilities-on-android

Here is stack trace:

Caused by java.lang.SecurityException: Package android does not belong to 10186
       at android.os.Parcel.createExceptionOrNull(Parcel.java:2373)
       at android.os.Parcel.createException(Parcel.java:2357)
       at android.os.Parcel.readException(Parcel.java:2340)
       at android.os.Parcel.readException(Parcel.java:2282)
       at android.net.IConnectivityManager$Stub$Proxy.getNetworkCapabilities(IConnectivityManager.java:2456)
       at android.net.ConnectivityManager.getNetworkCapabilities(ConnectivityManager.java:1385)
       at com.google.android.exoplayer2.scheduler.Requirements.isInternetConnectivityValidated(Requirements.java:215)
       at com.google.android.exoplayer2.scheduler.Requirements.getNotMetNetworkRequirements(Requirements.java:162)
       at com.google.android.exoplayer2.scheduler.Requirements.getNotMetRequirements(Requirements.java:137)
       at com.google.android.exoplayer2.scheduler.RequirementsWatcher.start(RequirementsWatcher.java:86)
       at com.google.android.exoplayer2.offline.DownloadManager.<init>(DownloadManager.java:278)
       at com.google.android.exoplayer2.offline.DownloadManager.<init>(DownloadManager.java:230)

ExoPlayer version: 2.12.2

Seems like you need to wrap this line into try catch:
https://github.com/google/ExoPlayer/blob/r2.15.0/library/core/src/main/java/com/google/android/exoplayer2/scheduler/Requirements.java#L215

[ojw28]

This issue was fixed in Android 12, by https://android-review.googlesource.com/c/platform/frameworks/base/+/1758029/. We'll add a try/catch for Android 11 devices that don't get patched. We'll return true from the catch block (i.e., assume network capability is validated), which is what we return from the method on API levels below 24 anyway.