CEA608: PAINT-ON Mode must keep the last shown captions on the screen#5147
Merged
ojw28 merged 1 commit intogoogle:dev-v2from Dec 5, 2018
Merged
CEA608: PAINT-ON Mode must keep the last shown captions on the screen#5147ojw28 merged 1 commit intogoogle:dev-v2from
ojw28 merged 1 commit intogoogle:dev-v2from
Conversation
[Problem] PAINT-ON mode is not implemented. From the compliance tests: * RDC command has no effect except to select paint-on style. * Next data are written directly to the display upon receipt. * If other captioning is already on the screen, the four-row limit is still in effect. [Solution] It is a rare use case, we do not support overriding characters in existing cueBuilders as PAINT-ON would require. But several compliance tests check if the screen is cleared when the mode switch happens. We must keep the old captions when switching to PAINT-ON mode [Test] - Live Over-the-Air content, beginning of commercials often uses PAINT-ON mode
Contributor
|
Looks fine to merge |
Contributor
Author
|
Shall I add the next change on top of this in a new pull request? Shall I wait till this one gets merged so the branches have no conflicts? |
Contributor
|
Does it need to be on top at all? Unless the next change happens to be touching the same lines of code, I'd expect it to be possible to prepare it on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PAINT-ON mode is not implemented. From compliance tests:
Solution
It is a rare use case, we do not support overriding characters in
existing cueBuilders as PAINT-ON would require. But the screen
must not be cleared when the mode switch happens.
We must keep the old captions when switching to PAINT-ON mode
Test
PAINT-ON mode