Conversation
ybai001
commented
Dec 24, 2018
- Add AC-4 MIME type definition
- Add AC-4 format support in Mp4Extractor and TsExtractor
- Add AC-4 Extractor
- Add AC-4 playback support in MPEG-4, MPEG-DASH, TS and HLS
Pull from google:dev-v2
Pull from google/ExoPlayer dev-v2
* Add AC-4 MIME type definition * Add AC-4 format support in Mp4Extractor and TsExtractor * Add AC-4 Extractor * Add AC-4 playback support in MPEG-4, MPEG-DASH, TS and HLS
andrewlewis
left a comment
There was a problem hiding this comment.
Do you have a sample .ac4 stream that could be used to add an Ac4ExtractorTest just like Ac3ExtractorTest?
This looks good to submit once that's added and the comments are addressed. Thanks!
...ary/core/src/main/java/com/google/android/exoplayer2/extractor/DefaultExtractorsFactory.java
Show resolved
Hide resolved
library/core/src/main/java/com/google/android/exoplayer2/audio/MediaCodecAudioRenderer.java
Show resolved
Hide resolved
...y/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4Extractor.java
Outdated
Show resolved
Hide resolved
library/core/src/main/java/com/google/android/exoplayer2/extractor/ts/Ac4Reader.java
Outdated
Show resolved
Hide resolved
library/core/src/main/java/com/google/android/exoplayer2/audio/Ac4Util.java
Outdated
Show resolved
Hide resolved
library/core/src/main/java/com/google/android/exoplayer2/audio/Ac4Util.java
Show resolved
Hide resolved
library/core/src/main/java/com/google/android/exoplayer2/audio/Ac4Util.java
Show resolved
Hide resolved
I talked with content creation team. It should be OK to add a sample .ac4 file. After I get approval from legal team, I'll add it into this contribution. |
Hi, Andrew, |
|
@ybai001 You can set the field |
* Add AC-4 MIME type definition * Add AC-4 format support in Mp4Extractor and TsExtractor * Add AC-4 Extractor * Add AC-4 playback support in MPEG-4, MPEG-DASH, TS and HLS
...y/core/src/main/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4Extractor.java
Show resolved
Hide resolved
* Add AC-4 MIME type definition * Add AC-4 format support in Mp4Extractor and TsExtractor * Add AC-4 Extractor * Add AC-4 playback support in MPEG-4, MPEG-DASH, TS and HLS
library/core/src/main/java/com/google/android/exoplayer2/audio/Ac4Util.java
Outdated
Show resolved
Hide resolved
library/core/src/main/java/com/google/android/exoplayer2/audio/Ac4Util.java
Show resolved
Hide resolved
library/core/src/main/java/com/google/android/exoplayer2/audio/Ac4Util.java
Show resolved
Hide resolved
* remove field mimeType in Ac4Util.java * change constant CHANNEL_COUNT_2 to private in Ac4Util.java
|
Sorry for the untidy commit history. I‘m not familiar with the working process on GitHub. |
andrewlewis
left a comment
There was a problem hiding this comment.
Looks good, thanks! This pull request will automatically be marked as merged when we submit this internally and update the development branch.