Handle trailing semicolon on RTSP fmtp attribute#9247
Merged
christosts merged 2 commits intogoogle:dev-v2from Aug 4, 2021
colinbarr:dev-v2-rtsp-fmtp-trailing-semicolon
Merged
Handle trailing semicolon on RTSP fmtp attribute#9247christosts merged 2 commits intogoogle:dev-v2from colinbarr:dev-v2-rtsp-fmtp-trailing-semicolon
christosts merged 2 commits intogoogle:dev-v2from
colinbarr:dev-v2-rtsp-fmtp-trailing-semicolon
Conversation
claincly
requested changes
Aug 3, 2021
library/rtsp/src/main/java/com/google/android/exoplayer2/source/rtsp/MediaDescription.java
Outdated
Show resolved
Hide resolved
christosts
added a commit
that referenced
this pull request
Aug 11, 2021
…icolon PiperOrigin-RevId: 388713101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented here, an
ArrayIndexOutOfBoundsExceptionoccurs if ana=fmtpline from an RTSP SDP response ends with a trailing semicolon. This change switches from using a limit of -1 on the Stringsplit(...)function via the Util class when parsing fmtp parameters, to using the implicit limit of 0. As a result, empty trailing strings are discarded which avoids this error condition.Fixes #9114