Conversation
| public final class MlpUtil { | ||
|
|
||
| /** The channel count of MLP stream. */ | ||
| // TODO: Parse MLP stream channel count. |
There was a problem hiding this comment.
Is this intended that this TODO has not been implemented?
| Mp4Extractor::new, "media/mp4/sample_with_color_info.mp4", simulationConfig); | ||
|
|
||
| @Test | ||
| public void mp4SampleWithDolbyTrueHDTrack() throws Exception { |
There was a problem hiding this comment.
This test doesn't pass. The changes also seem to have broken test mp4SampleWithAc4Track.
There was a problem hiding this comment.
I've messed up while rebasing. First a closing bracket } is missing on line 104.
As of the regression on AC4, I have indeed broken it while moving most of the readSample method code into a readSample1 method.
I have now fixed both issues in an updated set of commits.
There was a problem hiding this comment.
The mp4SampleWithDolbyTrueHDTrack() test still fails when simulating i/o errors but I am not quite sure how to debug this because don't quite understand how i/o errors get injected.
| * @return One of the {@code RESULT_*} flags in {@link Extractor}. | ||
| * @throws IOException If an error occurs reading from the input. | ||
| */ | ||
| private int readSample(ExtractorInput input, PositionHolder positionHolder) throws IOException { |
There was a problem hiding this comment.
The method readSample should return as often as possible so it should ideally read only one sample before returning. To avoid that, you can use a rechunker as in the MatroskaExtractor that would check whether sampleMetadata should be called or not.
There was a problem hiding this comment.
I think that I get it... you mean "don't change the readSample to read 16 samples a time but to issue the metadata only once every 16 samples for TrueHD" ...
I'll try to implement this.
Extract 16 access units per readSample call to align with what's done in MKV extraction. Signed-off-by: glass <glass@dolby.com>
Signed-off-by: glass <glass@dolby.com>
g-lass
force-pushed
the
dev-v2-truehd
branch
from
0000a2a to
2911bf7
Compare
|
I have inadvertently deleted the branch while pushing my latest changes upstream.... |
2 participants
Hi
I would like to enable the extraction of Dolby TrueHD streams from ISOBMF files.
For this extraction, I have reused the bundling of 16 access units (referred as samples in MP4 files) introduced with the extraction of Dolby TrueHD from MKV files.
The second commit provides a corresponding MP4 test vector and extraction dumps.
Fragmented MP4 has not been addressed in these commits.
Regards
gael