Document Agent Skills feature in ADK Go#1687
Merged
Merged
Conversation
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
koverholt
requested changes
Apr 27, 2026
koverholt
left a comment
koverholt
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR to add Go support to the Skills docs! The API usage and import paths look correct against the adk-go v1.2.0 source.
Left some comments, mostly around small code issues in the Go snippets and a few structural/formatting suggestions. The main substantive feedback is on the "Provision Skills dynamically" section, which could use some reworking.
foxfrikses
force-pushed
the
update-skills-doc-for-adk-go
branch
from
4f30def to
4720cc1
Compare
foxfrikses
force-pushed
the
update-skills-doc-for-adk-go
branch
from
4720cc1 to
c073c48
Compare
Contributor
Author
|
Thank you for the review! I believe I addressed all your comments. |
koverholt
approved these changes
Apr 28, 2026
koverholt
left a comment
koverholt
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for working through all of the issues. The updated content LGTM, merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.