Skip to content

docs(memory): refresh against current adk-python APIs#1700

Merged
koverholt merged 3 commits into
google:mainfrom
GWeale:memory-docs-refresh
Apr 28, 2026
Merged

docs(memory): refresh against current adk-python APIs#1700
koverholt merged 3 commits into
google:mainfrom
GWeale:memory-docs-refresh

Conversation

@GWeale

@GWeale GWeale commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

The memory page has drifted from the implementation:

  • The MultiMemoryAgent example raises ValueError on construction
    (assigns to a Pydantic model with extra="forbid").
  • The auto-save callback reaches into the private _invocation_context
    attribute when public Context.add_session_to_memory() exists.
  • The "MemoryService Role" section is missing add_events_to_memory
    and add_memory.
  • The comparison table is missing VertexAiRagMemoryService (a third
    bundled implementation).
  • "Searching Memory Within a Tool" has Go/TS/Java but no Python tab.
  • "How Memory Works in Practice" describes the wrong return type
    (MemoryResult; actual is MemoryEntry) and shows positional args
    for search_memory (it's keyword-only).

This PR refreshes the page against adk-python 1.31.0. The replacement
two-memory example is tool-based (no Agent subclassing) and verified
to construct against current adk-python.

The memory page has drifted from the implementation. The MultiMemoryAgent
example raises ValueError on construction (assigning to a Pydantic model
with extra="forbid"), the auto-save callback reaches into the private
_invocation_context attribute when public Context.add_session_to_memory()
exists, and the API surface description is missing add_events_to_memory,
add_memory, and the third memory service (VertexAiRagMemoryService).
@netlify

netlify Bot commented Apr 28, 2026

Copy link
Copy Markdown

Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit 3fa2c73
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/69f0fd4b5c2f5a0008e7a40f
😎 Deploy Preview https://deploy-preview-1700--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@koverholt koverholt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates! ❤️

I updated some product names (Vertex AI -> Agent Platform) in the prose for consistency, and I will open a new PR to make RAG Engine rename updates across the docs, including this page.

LGTM, merging.

@koverholt koverholt merged commit 78dbb44 into google:main Apr 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants