Skip to content

Kotlin snippets fixes#1770

Merged
koverholt merged 7 commits into
mainfrom
kotlin-build
May 19, 2026
Merged

Kotlin snippets fixes#1770
koverholt merged 7 commits into
mainfrom
kotlin-build

Conversation

@ToniCorinne

@ToniCorinne ToniCorinne commented May 19, 2026

Copy link
Copy Markdown
Member
  • Fix ktlint_code_style
  • Lint cleanup of existing snippets
  • Migrating from Map to typed data classes in FuncTool.kt and LongRunningTool.kt
  • Adding gradle wrapper

@ToniCorinne ToniCorinne requested a review from koverholt May 19, 2026 17:46
@netlify

netlify Bot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit b9f99d9
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/6a0ca1c169714400086144f6
😎 Deploy Preview https://deploy-preview-1770--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented May 19, 2026

Copy link
Copy Markdown

Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit e59310a
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/6a0cc7adf874f6000894e5b8
😎 Deploy Preview https://deploy-preview-1770--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@koverholt koverholt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KSP return type fixes are working. Formatting looks good. Thanks!

Still failing on an unused import and lots of warnings about ktlint_code_style = google being unrecognized in .editorconfig.

@ToniCorinne

Copy link
Copy Markdown
Member Author

@koverholt Fixes have been applied.

@koverholt koverholt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the Kotlin CI tests! LGTM. Left one comment but not blocking. Will merge after ADK 2.0 docs PR is in to avoid additional conflicts / noise for that.

Comment thread examples/kotlin/build.gradle.kts
@koverholt koverholt merged commit 27e1303 into main May 19, 2026
6 of 7 checks passed
@koverholt koverholt deleted the kotlin-build branch May 19, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants