Add in Datadog LLM Observability Documentation#998
Conversation
…enner/datadog-agent-observability
Co-authored-by: Barry Eom <31739208+barieom@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @sabrenner, thanks for the PR and contribution. This functionality looks great, and the mention of ADK on the LLM observability page is really nice! I'd like to write up a sample agent on this page to help users get started, and update the https://gist.github.com/koverholt/8e754e2c26e3c16635c051f524ab049d What's the best way for us to troubleshoot that together? Should I open an issue in https://github.com/DataDog/dd-trace-py? |
|
Actually it looks like this issue captures exactly what I ran into, which is preventing traces from being sent: So we would want to get that resolved before publishing these docs. |
|
@koverholt Thank you for flagging that issue, yes definitely agree we should get that issue resolved first. I'll get it fixed and released, and then follow up back here once it is! ETA is hopefully within the next couple of weeks (just due to release cycle timings, although taking a look at the issue hopefully the fix won't be too complicated) 😄 |
|
Hi @koverholt! Just wanted to leave an update here that the fix for this has been merged, and will be released next week, at which point I think we'll be unblocked here. I'll ping you here again when it is released but just wanted to keep you in the loop! |
|
Hi @koverholt, this fix was released in |
|
Thanks for the update and the fix! ❤️ I will test this again with the latest version. In the meantime, the Contributor License Agreement (CLA) test is failing for two GitHub accounts in this PR, can you check the build output for more information on signing CLAs? https://github.com/google/adk-docs/pull/998/checks?check_run_id=56814475201 |
|
@sabrenner, the good news is that the error that I ran into before is resolved in Pinning to version 3 of ddtrace in these docs seems suboptimal, so let's wait until 4.1.0 is available before we publish to minimize the likelihood of users running into the error with 4.0.0. |
|
Thank you so much for the feedback and your help so far @koverholt! I've pushed up some commits which address your comments. The fix has also been released in I will also look into getting the CLA check resolved 😄 |
|
Nice, thanks for the update @sabrenner and working through all of the issues with us. 🎉 I tested and can confirm that traces are working as expected and This is ready to be merged as soon as the CLAs are signed. |
…enner/datadog-agent-observability
✅ Deploy Preview for adk-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@joefernandez thanks for the feedback! I have pushed up changes and verified that it looks OK running the docs locally, happy to apply any more feedback 😄 Apologies for this PR falling of my radar for a little bit, but I am working on getting the CLA signed ASAP. Thank you both for the reviews so far! |
koverholt
left a comment
There was a problem hiding this comment.
Updates LGTM, thanks so much for getting things into the new format. Approving this PR, so let us know when the CLA is signed and we can merge. And thanks again for the contribution and integration!
c34b1e4 to
9d85250
Compare
|
Thanks for the updates to the CLA. There is another co-author of commit 7e78368, github username Let me know if it's easy to add that user to the CLA, or alternatively you could open a new PR with the same content but only your account in the commit history. |
|
@koverholt Thanks for following up! I'll opt to open a new PR in this case, and will link it to this one 🙇 |
|
Closing this PR as a new one has been opened with the same content in #1699 |
This PR adds in Datadog LLM Observability documentation for instrumenting stacks using the Google ADK. Datadog has released auto-instrumentation support for this in the
ddtracepython package within the past couple of months, and are looking to add our presence here as part of the suite of existing listed observability vendors.Please let me know what extra work is needs to be done on this as applicable and I am happy to iterate and push up changes! Thanks to reviewers in advance!