Skip to content

Add in Datadog LLM Observability Documentation#998

Closed
sabrenner wants to merge 14 commits into
google:mainfrom
sabrenner:sabrenner/datadog-agent-observability
Closed

Add in Datadog LLM Observability Documentation#998
sabrenner wants to merge 14 commits into
google:mainfrom
sabrenner:sabrenner/datadog-agent-observability

Conversation

@sabrenner

Copy link
Copy Markdown
Contributor

This PR adds in Datadog LLM Observability documentation for instrumenting stacks using the Google ADK. Datadog has released auto-instrumentation support for this in the ddtrace python package within the past couple of months, and are looking to add our presence here as part of the suite of existing listed observability vendors.

Please let me know what extra work is needs to be done on this as applicable and I am happy to iterate and push up changes! Thanks to reviewers in advance!

sabrenner and others added 4 commits October 22, 2025 15:15
@google-cla

google-cla Bot commented Nov 20, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@koverholt koverholt self-requested a review November 20, 2025 20:10
@koverholt

Copy link
Copy Markdown
Collaborator

Hi @sabrenner, thanks for the PR and contribution. This functionality looks great, and the mention of ADK on the LLM observability page is really nice!

I'd like to write up a sample agent on this page to help users get started, and update the ddtrace-run command to actually run the agent and generate traces. I can help with that. However, when trying things out, I ran into the following error:

https://gist.github.com/koverholt/8e754e2c26e3c16635c051f524ab049d

What's the best way for us to troubleshoot that together? Should I open an issue in https://github.com/DataDog/dd-trace-py?

@koverholt

Copy link
Copy Markdown
Collaborator

Actually it looks like this issue captures exactly what I ran into, which is preventing traces from being sent:

DataDog/dd-trace-py#15174

So we would want to get that resolved before publishing these docs.

@koverholt koverholt self-assigned this Nov 20, 2025
@sabrenner

Copy link
Copy Markdown
Contributor Author

@koverholt Thank you for flagging that issue, yes definitely agree we should get that issue resolved first. I'll get it fixed and released, and then follow up back here once it is! ETA is hopefully within the next couple of weeks (just due to release cycle timings, although taking a look at the issue hopefully the fix won't be too complicated) 😄

@sabrenner

Copy link
Copy Markdown
Contributor Author

Hi @koverholt! Just wanted to leave an update here that the fix for this has been merged, and will be released next week, at which point I think we'll be unblocked here. I'll ping you here again when it is released but just wanted to keep you in the loop!

@sabrenner

Copy link
Copy Markdown
Contributor Author

Hi @koverholt, this fix was released in ddtrace==3.19.1 and will be in the upcoming 4.1.0 release as well. Let me know if the 3.19.1 version works or if there are any more issues, but otherwise I think if it's all good we're good to move forward here!

@koverholt

Copy link
Copy Markdown
Collaborator

Thanks for the update and the fix! ❤️ I will test this again with the latest version.

In the meantime, the Contributor License Agreement (CLA) test is failing for two GitHub accounts in this PR, can you check the build output for more information on signing CLAs? https://github.com/google/adk-docs/pull/998/checks?check_run_id=56814475201

Comment thread docs/observability/datadog.md Outdated
Comment thread docs/integrations/datadog.md
@koverholt

Copy link
Copy Markdown
Collaborator

@sabrenner, the good news is that the error that I ran into before is resolved in ddtrace==3.19.1. However, ddtrace==4.0.0 is the latest package version that gets installed when pip install ddtrace is run, and the error still occurs since (as you mentioned) the fix is not available in that branch until 4.1.0 is released.

Pinning to version 3 of ddtrace in these docs seems suboptimal, so let's wait until 4.1.0 is available before we publish to minimize the likelihood of users running into the error with 4.0.0.

@sabrenner

Copy link
Copy Markdown
Contributor Author

Thank you so much for the feedback and your help so far @koverholt! I've pushed up some commits which address your comments. The fix has also been released in ddtrace==4.1.0.

I will also look into getting the CLA check resolved 😄

@koverholt

Copy link
Copy Markdown
Collaborator

Nice, thanks for the update @sabrenner and working through all of the issues with us. 🎉

I tested and can confirm that traces are working as expected and ddtrace==4.1.2 is the current version that gets installed.

This is ready to be merged as soon as the CLAs are signed.

Comment thread docs/integrations/assets/datadog-observability.png
Comment thread docs/integrations/datadog.md
Comment thread docs/observability/datadog.md Outdated
Comment thread docs/integrations/datadog.md
Comment thread mkdocs.yml Outdated
@netlify

netlify Bot commented Apr 22, 2026

Copy link
Copy Markdown

Deploy Preview for adk-docs-preview ready!

Name Link
🔨 Latest commit 9d85250
🔍 Latest deploy log https://app.netlify.com/projects/adk-docs-preview/deploys/69f0e0fd44c42300082bb2ba
😎 Deploy Preview https://deploy-preview-998--adk-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sabrenner

Copy link
Copy Markdown
Contributor Author

@joefernandez thanks for the feedback! I have pushed up changes and verified that it looks OK running the docs locally, happy to apply any more feedback 😄

Apologies for this PR falling of my radar for a little bit, but I am working on getting the CLA signed ASAP. Thank you both for the reviews so far!

@koverholt koverholt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates LGTM, thanks so much for getting things into the new format. Approving this PR, so let us know when the CLA is signed and we can merge. And thanks again for the contribution and integration!

@koverholt koverholt force-pushed the sabrenner/datadog-agent-observability branch 4 times, most recently from c34b1e4 to 9d85250 Compare April 28, 2026 16:31
@koverholt

Copy link
Copy Markdown
Collaborator

Thanks for the updates to the CLA. There is another co-author of commit 7e78368, github username barieom that has not signed the CLA (see CI log).

Let me know if it's easy to add that user to the CLA, or alternatively you could open a new PR with the same content but only your account in the commit history.

@sabrenner

Copy link
Copy Markdown
Contributor Author

@koverholt Thanks for following up! I'll opt to open a new PR in this case, and will link it to this one 🙇

@sabrenner

Copy link
Copy Markdown
Contributor Author

Closing this PR as a new one has been opened with the same content in #1699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants