Skip to content

chore: Create pyproject.toml#3

Merged
hangfei merged 4 commits into
mainfrom
hangfei-patch-2
Sep 4, 2025
Merged

chore: Create pyproject.toml#3
hangfei merged 4 commits into
mainfrom
hangfei-patch-2

Conversation

@hangfei

@hangfei hangfei commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hangfei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a pyproject.toml file to streamline and standardize the project's build process, dependency management, and development tool configurations. This change aims to improve maintainability, ensure consistent code quality, and simplify the setup for contributors by consolidating project-specific settings into a single, widely adopted standard.

Highlights

  • New Project Configuration File: A new pyproject.toml file has been added to the repository, centralizing project metadata, build system configuration, and various development tool settings.
  • Standardized Build System: The project now uses flit_core as its build backend, aligning with modern Python packaging standards and simplifying the build and distribution process.
  • Integrated Development Tooling: Configurations for pyink (code formatter), isort (import sorter), pytest (testing framework), and mypy (static type checker) are now defined within pyproject.toml, ensuring consistent development practices across the project.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the pyproject.toml file, which is a great step towards modernizing the project's packaging and tooling configuration. The setup for flit, pyink, isort, pytest, and mypy looks solid. I've left a couple of suggestions to improve dependency management and correct project URLs for better clarity and stability.

Comment thread pyproject.toml
dependencies = [
# go/keep-sorted start
"google-genai>=1.21.1, <2.0.0", # Google GenAI SDK
"google-adk", # Google ADK

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The google-adk dependency is not version-pinned. This can lead to your package breaking if a new version of google-adk with backward-incompatible changes is released. It's a best practice to specify a version range to ensure your project's stability, similar to how google-genai is specified (e.g., "google-adk >= A.B.C, < D.E.F").

Comment thread pyproject.toml Outdated
Comment on lines +36 to +37
repository = "https://github.com/google/adk-python"
changelog = "https://github.com/google/adk-python/blob/main/CHANGELOG.md"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository and changelog URLs appear to point to the core adk-python repository instead of this community repository. Based on the project name (google-adk-community) and the README.md, these should probably point to the adk-python-community repository.

Suggested change
repository = "https://github.com/google/adk-python"
changelog = "https://github.com/google/adk-python/blob/main/CHANGELOG.md"
repository = "https://github.com/google/adk-python-community"
changelog = "https://github.com/google/adk-python-community/blob/main/CHANGELOG.md"

@hangfei hangfei merged commit 3621469 into main Sep 4, 2025
1 check passed
@hangfei hangfei deleted the hangfei-patch-2 branch September 4, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants