Skip to content

Conversation

@Colstuwjx
Copy link
Contributor

Fixed #480

Generated mysql table:

mysql> desc events;
+----------------------------+---------------+------+-----+---------+-------+
| Field                      | Type          | Null | Key | Default | Extra |
+----------------------------+---------------+------+-----+---------+-------+
| id                         | varchar(128)  | NO   | PRI | NULL    |       |
| app_name                   | varchar(128)  | NO   | PRI | NULL    |       |
| user_id                    | varchar(128)  | NO   | PRI | NULL    |       |
| session_id                 | varchar(128)  | NO   | PRI | NULL    |       |
| invocation_id              | varchar(256)  | NO   |     | NULL    |       |
| author                     | varchar(256)  | NO   |     | NULL    |       |
| branch                     | varchar(256)  | YES  |     | NULL    |       |
| timestamp                  | datetime(6)   | NO   |     | NULL    |       |
| content                    | longtext      | YES  |     | NULL    |       |
| actions                    | blob          | NO   |     | NULL    |       |
| long_running_tool_ids_json | text          | YES  |     | NULL    |       |
| grounding_metadata         | longtext      | YES  |     | NULL    |       |
| partial                    | tinyint(1)    | YES  |     | NULL    |       |
| turn_complete              | tinyint(1)    | YES  |     | NULL    |       |
| error_code                 | varchar(256)  | YES  |     | NULL    |       |
| error_message              | varchar(1024) | YES  |     | NULL    |       |
| interrupted                | tinyint(1)    | YES  |     | NULL    |       |
+----------------------------+---------------+------+-----+---------+-------+
17 rows in set (0.24 sec)

Event data from api:

{
    "id": "c4070feb-f210-486b-a410-aa0fcf9f6360",
    "appName": "chatbot_app",
    "userId": "user",
    "state": {},
    "events": [
        {
            "content": {
                "parts": [
                    {
                        "text": "hi"
                    }
                ],
                "role": "user"
            },
            "invocationId": "e-919a300a-758a-49da-96ae-4b4ab6ee4a76",
            "author": "user",
            "actions": {
                "stateDelta": {},
                "artifactDelta": {},
                "requestedAuthConfigs": {}
            },
            "longRunningToolIds": [],
            "id": "nNwEB5e0",
            "timestamp": 1748490022.719857
        },
        {
            ...
            "actions": {
                "stateDelta": {},
                "artifactDelta": {},
                "requestedAuthConfigs": {}
            },
            "longRunningToolIds": [],
            "id": "wPo1Cn4L",
            "timestamp": 1748490025.788181
        },
        {
            ...
            "actions": {
                "stateDelta": {},
                "artifactDelta": {},
                "transferToAgent": "probing_agent",
                "requestedAuthConfigs": {}
            },
            "longRunningToolIds": [],
            "id": "9NWoeTr6",
            "timestamp": 1748490032.351483
        },
        {
           ...
            "actions": {
                "stateDelta": {},
                "artifactDelta": {},
                "requestedAuthConfigs": {}
            },
            "longRunningToolIds": [],
            "id": "9b1mu6u9",
            "timestamp": 1748490035.395766
        }
    ],
    "lastUpdateTime": 1748475639.0
}

Thanks.

Copy link
Collaborator

@DeanChensj DeanChensj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DeanChensj DeanChensj added the ready to pull [Status] This PR is ready to be importing back to Google label May 29, 2025
@Colstuwjx
Copy link
Contributor Author

Could you format the code with https://github.com/google/adk-python/blob/main/autoformat.sh?

@DeanChensj done, thanks.

@Colstuwjx
Copy link
Contributor Author

not sure why the UT failed, seems like the latest merged commit also has this issue

@DeanChensj
Copy link
Collaborator

There was a issue blocking new changes from google internal syncing to the github, it is now resolved. Right now there is still unit tests failing irrelevant to your change.

copybara-service bot pushed a commit that referenced this pull request May 29, 2025
Copybara import of the project:

--
c62a0a6 by Jacky W <wjx_colstu@hotmail.com>:

--
59c0606 by Jacky W <wjx_colstu@hotmail.com>:

fix: add cache_ok option to remove sa warning.

--
1922599 by Jacky W <wjx_colstu@hotmail.com>:

chore: format code.
COPYBARA_INTEGRATE_REVIEW=#1001 from Colstuwjx:fix/issue-480-precise-mysql-timestamp 50e764f
PiperOrigin-RevId: 764853016
@DeanChensj
Copy link
Collaborator

merged in 841e10a

@DeanChensj DeanChensj closed this May 29, 2025
whhlct pushed a commit to whhlct/adk-python that referenced this pull request Jun 6, 2025
Copybara import of the project:

--
c62a0a6 by Jacky W <wjx_colstu@hotmail.com>:

--
59c0606 by Jacky W <wjx_colstu@hotmail.com>:

fix: add cache_ok option to remove sa warning.

--
1922599 by Jacky W <wjx_colstu@hotmail.com>:

chore: format code.
COPYBARA_INTEGRATE_REVIEW=google#1001 from Colstuwjx:fix/issue-480-precise-mysql-timestamp 50e764f
PiperOrigin-RevId: 764853016
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
Copybara import of the project:

--
c62a0a6 by Jacky W <wjx_colstu@hotmail.com>:

--
59c0606 by Jacky W <wjx_colstu@hotmail.com>:

fix: add cache_ok option to remove sa warning.

--
1922599 by Jacky W <wjx_colstu@hotmail.com>:

chore: format code.
COPYBARA_INTEGRATE_REVIEW=google#1001 from Colstuwjx:fix/issue-480-precise-mysql-timestamp 50e764f
PiperOrigin-RevId: 764853016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be importing back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mysql timestamp problem

2 participants