-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: introduce PreciseTimestamp to fix mysql datetime precision issue. #1001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: introduce PreciseTimestamp to fix mysql datetime precision issue. #1001
Conversation
DeanChensj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you format the code with https://github.com/google/adk-python/blob/main/autoformat.sh?
@DeanChensj done, thanks. |
|
not sure why the UT failed, seems like the latest merged commit also has this issue |
|
There was a issue blocking new changes from google internal syncing to the github, it is now resolved. Right now there is still unit tests failing irrelevant to your change. |
Copybara import of the project: -- c62a0a6 by Jacky W <wjx_colstu@hotmail.com>: -- 59c0606 by Jacky W <wjx_colstu@hotmail.com>: fix: add cache_ok option to remove sa warning. -- 1922599 by Jacky W <wjx_colstu@hotmail.com>: chore: format code. COPYBARA_INTEGRATE_REVIEW=#1001 from Colstuwjx:fix/issue-480-precise-mysql-timestamp 50e764f PiperOrigin-RevId: 764853016
|
merged in 841e10a |
Copybara import of the project: -- c62a0a6 by Jacky W <wjx_colstu@hotmail.com>: -- 59c0606 by Jacky W <wjx_colstu@hotmail.com>: fix: add cache_ok option to remove sa warning. -- 1922599 by Jacky W <wjx_colstu@hotmail.com>: chore: format code. COPYBARA_INTEGRATE_REVIEW=google#1001 from Colstuwjx:fix/issue-480-precise-mysql-timestamp 50e764f PiperOrigin-RevId: 764853016
Copybara import of the project: -- c62a0a6 by Jacky W <wjx_colstu@hotmail.com>: -- 59c0606 by Jacky W <wjx_colstu@hotmail.com>: fix: add cache_ok option to remove sa warning. -- 1922599 by Jacky W <wjx_colstu@hotmail.com>: chore: format code. COPYBARA_INTEGRATE_REVIEW=google#1001 from Colstuwjx:fix/issue-480-precise-mysql-timestamp 50e764f PiperOrigin-RevId: 764853016
Fixed #480
Generated mysql table:
Event data from api:
Thanks.