Skip to content

feat(telemetry): Refactor "telemetry.py" to "telemetry/recording/__init__.py" to unblock further telemetry improvements.#569

Closed
michaelsafyan wants to merge 10 commits into
google:mainfrom
michaelsafyan:telemetry_prefactor
Closed

feat(telemetry): Refactor "telemetry.py" to "telemetry/recording/__init__.py" to unblock further telemetry improvements.#569
michaelsafyan wants to merge 10 commits into
google:mainfrom
michaelsafyan:telemetry_prefactor

Conversation

@michaelsafyan

Copy link
Copy Markdown

This is a narrowly focused subset of the telemetry improvements proposed in #320 . As can be seen in pull request #320, making "telemetry" into a package and moving the existing logic into a "recording" sub-package will enable the creation of a "setup" package that is focused on telemetry initialization and wiring.

Once submitted, it will become possible to begin incrementally factoring out some of the "setup"-related files and contributing them (along with associated unit tests) in more narrowly focused updates.

See also #474 for additional motivation and context.

@michaelsafyan michaelsafyan changed the title [chore] Refactor "telemetry.py" to "telemetry/recording/__init__.py" to unblock further telemetry improvements. feat(telemetry) Refactor "telemetry.py" to "telemetry/recording/__init__.py" to unblock further telemetry improvements. May 5, 2025
@michaelsafyan michaelsafyan changed the title feat(telemetry) Refactor "telemetry.py" to "telemetry/recording/__init__.py" to unblock further telemetry improvements. feat(telemetry): Refactor "telemetry.py" to "telemetry/recording/__init__.py" to unblock further telemetry improvements. May 5, 2025
@DeanChensj DeanChensj requested a review from hangfei May 7, 2025 22:22

@hangfei hangfei left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we name the new package recording?

@hangfei

hangfei commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

Is this a backward compatible change?

@michaelsafyan michaelsafyan marked this pull request as draft July 11, 2025 16:07
@michaelsafyan

Copy link
Copy Markdown
Author

I've converted this to draft, because I had handed off related discussions/work to @aabmass

To answer your questions, though:

  • Why rename: because it enables separating out:
    • Logic to write (record) the telemetry
    • Logic to initialize Open Telemetry

It was intended as a factored out piece of:

#320

The move would enable this eventual tree structure:

  • telemetry/
    • setup/ <= logic to initialize Open Telemetry
    • recording/ <= logic to write traces

I believe @aabmass has an internal RFC with your team to discuss plans for ADK telemetry in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants