Skip to content

Conversation

@lucasnobre212
Copy link
Contributor

@lucasnobre212 lucasnobre212 commented May 16, 2025

Fixes #484

This PR adds support for parallel tool calls by creating an dict to keep track of the index and correctly appending the strings.

@lucasnobre212 lucasnobre212 changed the title Add support for parallel tool calling using SSE with LiteLLM feat: Add support for parallel tool calling using SSE with LiteLLM May 16, 2025
@lucasnobre212 lucasnobre212 changed the title feat: Add support for parallel tool calling using SSE with LiteLLM fix: Support for parallel tool calling using SSE with LiteLLM May 16, 2025
@lucasnobre212 lucasnobre212 marked this pull request as ready for review May 16, 2025 10:33
@lucasnobre212
Copy link
Contributor Author

I have tested using OpenAI and it works well.

@lucasnobre212 lucasnobre212 marked this pull request as draft May 16, 2025 10:37
@lucasnobre212 lucasnobre212 marked this pull request as ready for review May 16, 2025 10:38
Copy link
Collaborator

@selcukgun selcukgun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR!

@selcukgun selcukgun added the ready to pull [Status] This PR is ready to be importing back to Google label May 29, 2025
copybara-service bot pushed a commit that referenced this pull request May 29, 2025
--
cef3ca1 by Lucas Nobre <lucaas.sn@gmail.com>:

feat: Add index tracking to handle parallel tool call using litellm
COPYBARA_INTEGRATE_REVIEW=#759 from lucasnobre212:fix/issue_484 65e2293
PiperOrigin-RevId: 764902433
@selcukgun
Copy link
Collaborator

merged by copybara: 05f4834

@selcukgun selcukgun closed this May 29, 2025
whhlct pushed a commit to whhlct/adk-python that referenced this pull request Jun 6, 2025
--
cef3ca1 by Lucas Nobre <lucaas.sn@gmail.com>:

feat: Add index tracking to handle parallel tool call using litellm
COPYBARA_INTEGRATE_REVIEW=google#759 from lucasnobre212:fix/issue_484 65e2293
PiperOrigin-RevId: 764902433
coder-aditi pushed a commit to coder-aditi/adk-python that referenced this pull request Jul 2, 2025
--
cef3ca1 by Lucas Nobre <lucaas.sn@gmail.com>:

feat: Add index tracking to handle parallel tool call using litellm
COPYBARA_INTEGRATE_REVIEW=google#759 from lucasnobre212:fix/issue_484 65e2293
PiperOrigin-RevId: 764902433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull [Status] This PR is ready to be importing back to Google

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LiteLlm generate_content_async doesn't handle multiple tool calls in the same model response in SSE mode

2 participants