fix: separate thinking from text parts in streaming mode #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9a4k
force-pushed
the
separate-thinking-and-text-parts-in-stream-mode
branch
from
184c6cf to
7996288
Compare
Contributor
|
The changes are verified and work well for latest codes. |
genquan9
approved these changes
May 28, 2025
Contributor
genquan9
left a comment
genquan9
left a comment
There was a problem hiding this comment.
The changes are verified and work well.
seanzhou1023
approved these changes
May 29, 2025
seanzhou1023
added
ready to pull
seanzhou1023
added
the
ready to pull
Collaborator
|
merged in commit 795605a |
whhlct
pushed a commit
to whhlct/adk-python
that referenced
this pull request
Jun 6, 2025
Copybara import of the project: -- 7996288 by Almas Akchabayev <almas.akchabayev@gmail.com>: fix: separate thinking from text parts in streaming mode COPYBARA_INTEGRATE_REVIEW=google#777 from almeynman:separate-thinking-and-text-parts-in-stream-mode b63dcc7 PiperOrigin-RevId: 764561932
coder-aditi
pushed a commit
to coder-aditi/adk-python
that referenced
this pull request
Jul 2, 2025
Copybara import of the project: -- 7996288 by Almas Akchabayev <almas.akchabayev@gmail.com>: fix: separate thinking from text parts in streaming mode COPYBARA_INTEGRATE_REVIEW=google#777 from almeynman:separate-thinking-and-text-parts-in-stream-mode b63dcc7 PiperOrigin-RevId: 764561932
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #770
Tested with the same example as in the original issue and got event with 2 parts back correctly