Add DEVICE_FEATURE for depth clamp zero one#1074
Merged
Merged
Conversation
dj2
approved these changes
Jan 8, 2025
Contributor
Author
|
I see that the NDK autobuild is failing to find any of the tokens that are used in this change, but the version of the vulkan headers in DEPS does include them. Do you know if there's any special that I should be aware of around that? |
Collaborator
|
@dneto0 do you remember how the NDK build works? Does it use deps or something out of the NDK? Do we need to update it in some fashion? |
Collaborator
|
I think the in the Android.mk build the vulkan headers are taken from the NDK. The bots use ndk-r25b which I think is acouple of years old. I'll update the bots. |
Collaborator
|
The NDK r27c includes vulkan.h for 1.3.275, and the needed tokens are in there. |
Collaborator
|
#1076 updates the scripts to use NDK r27c. |
dneto0
force-pushed
the
gnl-depth-clamp
branch
from
8f8ffee to
0afc9db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.