Skip to content

Initialize data buffer. #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dj2 merged 2 commits into from
Oct 3, 2019
Merged

Initialize data buffer. #680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8898cad
Initialize data buffer.
dj2 Oct 2, 2019
dac8519
Fixup params
dj2 Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,15 @@ Result Buffer::SetDataWithOffset(const std::vector<Value>& data,
// this maybe the first time data is set into the buffer.
bytes_.resize(GetSizeInBytes());

// Set the new memory to zero to be on the safe side.
uint32_t new_space =
(static_cast<uint32_t>(data.size()) / format_->InputNeededPerElement()) *
format_->SizeInBytes();
assert(new_space + offset <= GetSizeInBytes());

if (new_space > 0)
memset(bytes_.data() + offset, 0, new_space);

if (data.size() > (ElementCount() * format_->InputNeededPerElement()))
return Result("Mismatched number of items in buffer");

Expand Down