Single privacy notice#2542
Draft
cjreynol wants to merge 4 commits into
Draft
Conversation
cjreynol
force-pushed
the
single_privacy_notice
branch
2 times, most recently
from
d42b48c to
d9647ec
Compare
To prevent needing to update multiple locations when changing how the notices work. Also, refactor how `validate_metrics_confirmation` works to prevent needing duplicate text in multiple branches of a conditional. I would try to migrate the `validate_metrics_confirmation` logic into the new `notirication` files, but it is going to get removed eventually. Bug: 511260927
If it has already been displayed, skip on future starts. Bug: 511260927
It cannot trigger off of the same file as the privacy notices, because this message happens later. Also, the confirmation dialog potentially happens between the privacy notices and the adjustment notice, so they cannot be combined together. Bug: 511260927
To further trim down `cvd create` output. Bug: 507537392
cjreynol
force-pushed
the
single_privacy_notice
branch
from
d9647ec to
2a8ac1c
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trimming the
cvd createoutput down further.Bug: 511260927